Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: fix a 500 during timeline creation + shutdown #10259

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 2, 2025

Problem

The test_create_churn_during_restart test fails if timeline creation calls return 500 errors (because the API shouldn't do it), and it's sometimes failing, for example:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-10256/12582034135/index.html#/testresult/3ce2e7045465012e

Summary of changes

  • Avoid handling UploadQueueShutDownOrStopped case as an Other (i.e. 500)

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)


Code coverage* (full report)

  • functions: 31.3% (8403 of 26881 functions)
  • lines: 48.0% (66688 of 139075 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9ce7646 at 2025-01-02T15:58:55.069Z :recycle:

@jcsp jcsp marked this pull request as ready for review January 2, 2025 16:14
@jcsp jcsp requested a review from a team as a code owner January 2, 2025 16:14
@jcsp jcsp requested a review from problame January 2, 2025 16:14
@jcsp jcsp added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit e9d30ed Jan 3, 2025
88 checks passed
@jcsp jcsp deleted the jcsp/timeline-creation-500 branch January 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants