Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: building compute_tools and local_proxy together #10257

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

conradludgate
Copy link
Contributor

Problem

Building local_proxy and compute_tools features the same dependency tree, but as they are currently built in separate clean layers all that progress is wasted. For our arm builds that's an extra 10 minutes.

Summary of changes

Combines the compute_tools and local_proxy build layers.

@conradludgate conradludgate requested a review from a team as a code owner January 2, 2025 12:27
@conradludgate conradludgate requested a review from ololobus January 2, 2025 12:27
@conradludgate
Copy link
Contributor Author

Before: 25m7s
After: 12m15s

Copy link

github-actions bot commented Jan 2, 2025

7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (8404 of 26881 functions)
  • lines: 47.9% (66685 of 139074 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0000d5e at 2025-01-02T16:12:27.553Z :recycle:

@conradludgate conradludgate force-pushed the conrad/merge-compute-tools-build branch from f00a3ff to 0000d5e Compare January 2, 2025 14:49
@conradludgate conradludgate added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 56e6ebf Jan 2, 2025
78 checks passed
@conradludgate conradludgate deleted the conrad/merge-compute-tools-build branch January 2, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants