Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proxy): pre-load native tls certificates and propagate compute client config #10182

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

conradludgate
Copy link
Contributor

Now that we construct the TLS client config for cancellation as well as connect, it feels appropriate to construct the same config once and re-use it elsewhere. It might also help should #7500 require any extra setup, so we can easily add it to all the appropriate call sites.

Copy link

github-actions bot commented Dec 18, 2024

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (4)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (8402 of 26881 functions)
  • lines: 47.9% (66681 of 139074 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
25b2de3 at 2024-12-30T16:51:14.375Z :recycle:

Base automatically changed from conrad/fully-remove-self-signed-compute-flag to main December 18, 2024 16:05
@conradludgate conradludgate force-pushed the conrad/pre-init-compute-tls-client-config branch from bbc799c to ad091c6 Compare December 18, 2024 16:07
@conradludgate conradludgate marked this pull request as ready for review December 30, 2024 09:12
@conradludgate conradludgate requested a review from a team as a code owner December 30, 2024 09:12
@conradludgate conradludgate force-pushed the conrad/pre-init-compute-tls-client-config branch from ad091c6 to 078a019 Compare December 30, 2024 09:13
proxy/src/bin/proxy.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@cloneable cloneable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@conradludgate conradludgate added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 38c7a2a Jan 2, 2025
82 checks passed
@conradludgate conradludgate deleted the conrad/pre-init-compute-tls-client-config branch January 2, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants