Skip to content

Commit

Permalink
Fix the connection error for extension tests (#10480)
Browse files Browse the repository at this point in the history
## Problem
The trust connection to the compute required for `pg_anon` was removed.
However, the PGPASSWORD environment variable was not added to
`docker-compose.yml`.
This caused connection errors, which were interpreted as success due to
errors in the bash script.
## Summary of changes
The environment variable was added, and the logic in the bash script was
fixed.
  • Loading branch information
a-masterov authored Jan 22, 2025
1 parent c283aaa commit f1473dd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions docker-compose/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ services:
neon-test-extensions:
profiles: ["test-extensions"]
image: ${REPOSITORY:-neondatabase}/neon-test-extensions-v${PG_TEST_VERSION:-16}:${TAG:-latest}
environment:
- PGPASSWORD=cloud_admin
entrypoint:
- "/bin/bash"
- "-c"
Expand Down
5 changes: 4 additions & 1 deletion docker-compose/run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ LIST=$( (echo -e "${SKIP//","/"\n"}"; ls -d -- *-src) | sort | uniq -u)
for d in ${LIST}
do
[ -d "${d}" ] || continue
psql -c "select 1" >/dev/null || break
if ! psql -w -c "select 1" >/dev/null; then
FAILED="${d} ${FAILED}"
break
fi
USE_PGXS=1 make -C "${d}" installcheck || FAILED="${d} ${FAILED}"
done
[ -z "${FAILED}" ] && exit 0
Expand Down

1 comment on commit f1473dd

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7521 tests run: 7126 passed, 0 failed, 395 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 33.5% (8494 of 25334 functions)
  • lines: 49.3% (71367 of 144677 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f1473dd at 2025-01-22T18:58:52.940Z :recycle:

Please sign in to comment.