Skip to content

Commit

Permalink
Unlock LFC mutex when LFC cache is disabled (#10235)
Browse files Browse the repository at this point in the history
## Problem

See #10233
`lfc_containsv` returns with holding lock when LFC was disabled.
This bug was introduced in commit  78938d1

## Summary of changes

Release lock before return.

Co-authored-by: Konstantin Knizhnik <[email protected]>
  • Loading branch information
knizhnik and Konstantin Knizhnik authored Jan 2, 2025
1 parent 38c7a2a commit b3cd883
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pgxn/neon/file_cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ lfc_cache_containsv(NRelFileInfo rinfo, ForkNumber forkNum, BlockNumber blkno,
}
else
{
LWLockRelease(lfc_lock);
return found;
}

Expand Down

1 comment on commit b3cd883

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7245 tests run: 6937 passed, 1 failed, 307 skipped (full report)


Failures on Postgres 16

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg16-github-actions-selfhosted]"
Flaky tests (3)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (8403 of 26881 functions)
  • lines: 48.0% (66688 of 139070 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b3cd883 at 2025-01-02T14:21:31.517Z :recycle:

Please sign in to comment.