Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
safekeeper: short-circuit interpreted wal sender (#10202)
## Problem Safekeeper may currently send a batch to the pageserver even if it hasn't decoded a new record. I think this is quite unlikely in the field, but worth adressing. ## Summary of changes Don't send anything if we haven't decoded a full record. Once this merges and releases, the `InterpretedWalRecords` struct can be updated to remove the Option wrapper for `next_record_lsn`.
- Loading branch information
628451d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7245 tests run: 6937 passed, 1 failed, 307 skipped (full report)
Failures on Postgres 16
test_storage_controller_many_tenants[github-actions-selfhosted]
: release-x86-64Flaky tests (3)
Postgres 17
test_subscriber_synchronous_commit
: release-x86-64test_timeline_archival_chaos
: release-arm64test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-rm]
: release-arm64Code coverage* (full report)
functions
:31.2% (8396 of 26876 functions)
lines
:47.9% (66634 of 139015 lines)
* collected from Rust tests only
628451d at 2024-12-19T16:26:03.731Z :recycle: