Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon-macros): Add Channel context for async functions and this support #1075

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

kjvalencik
Copy link
Member

Additionally, improves error messaging when incorrect types are provided. UI tests, via trybuild, are added to prevent regressions on errors.

@kjvalencik kjvalencik requested a review from dherman October 1, 2024 18:00
Base automatically changed from kv/extract-box to main October 7, 2024 17:40
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, and the tests are impressively thorough. Boxed(this) is especially powerful for custom native classes.

I left a couple detailed suggestions but they're up to you.

.gitignore Show resolved Hide resolved
crates/neon-macros/src/export/function/mod.rs Show resolved Hide resolved
test/ui/tests/fail/wrong-context.stderr Show resolved Hide resolved
crates/neon-macros/src/export/function/mod.rs Show resolved Hide resolved
…s` support

Additionally, improves error messaging when incorrect types are provided. UI tests, via trybuild, are added to prevent regressions on errors.
@kjvalencik kjvalencik force-pushed the kv/export-self-types branch from abf2084 to 4c77978 Compare October 7, 2024 20:47
@kjvalencik kjvalencik merged commit 2c8cd15 into main Oct 7, 2024
9 checks passed
@kjvalencik kjvalencik deleted the kv/export-self-types branch October 7, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants