fix(neon): Fix a panic when borrowing an empty buffer or typed array #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
force-pushed
the
kv/borrow-fix
branch
2 times, most recently
from
53e1ad7 to
8e85ff7
Compare
kjvalencik
force-pushed
the
kv/borrow-fix
branch
from
8e85ff7 to
70b5a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The borrow API currently panics if trying to borrow an empty buffer. This is because the pointer will be nil.
This PR adds guards for
length != 0. Additionally, the ledger skips adding/removing empty buffers.