Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-neon 0.3: Create Neon 1.0 project with default feature flags #1013

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

kjvalencik
Copy link
Member

No description provided.

@kjvalencik kjvalencik force-pushed the kv/remove-version-check branch from a513118 to 5ed5689 Compare December 8, 2023 17:48
@@ -1,5 +1,4 @@
{
"neon": "1.0.0",
"napi": "8",
"neon": "1",
Copy link
Member Author

@kjvalencik kjvalencik Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt cleaner because 1.0.0 and 1 mean the same thing without any additional specifiers.

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kjvalencik kjvalencik merged commit 09fce79 into main Dec 8, 2023
9 checks passed
@kjvalencik kjvalencik deleted the kv/remove-version-check branch December 8, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants