Merge pull request #1008 from neon-bindings/kv/to-future-fix

Avoid leaving a dangling future when handling a rejection in JsPromise::to_future

crates/neon/src/handle/mod.rs

@@ -80,10 +80,7 @@ pub struct Handle<'a, V: Value + 'a> {
 
 impl<'a, V: Value> Clone for Handle<'a, V> {
     fn clone(&self) -> Self {
-        Self {
-            value: self.value,
-            phantom: PhantomData,
-        }
+        *self
     }
 }
 

crates/neon/src/types_impl/boxed.rs

@@ -164,10 +164,7 @@ unsafe fn maybe_external_deref<'a>(env: Env, local: raw::Local) -> Option<&'a Bo
 // Custom `Clone` implementation since `T` might not be `Clone`
 impl<T: 'static> Clone for JsBoxInner<T> {
     fn clone(&self) -> Self {
-        Self {
-            local: self.local,
-            raw_data: self.raw_data,
-        }
+        *self
     }
 }
 

crates/neon/src/types_impl/promise.rs

@@ -186,7 +186,6 @@ impl JsPromise {
             + 'static,
     {
         let then = self.get::<JsFunction, _, _>(cx, "then")?;
-        let catch = self.get::<JsFunction, _, _>(cx, "catch")?;
 
         let (tx, rx) = oneshot::channel();
         let take_state = {
@@ -235,8 +234,11 @@ impl JsPromise {
             }
         })?;
 
-        then.exec(cx, Handle::new_internal(Self(self.0)), [resolve.upcast()])?;
-        catch.exec(cx, Handle::new_internal(Self(self.0)), [reject.upcast()])?;
+        then.exec(
+            cx,
+            Handle::new_internal(Self(self.0)),
+            [resolve.upcast(), reject.upcast()],
+        )?;
 
         Ok(JsFuture { rx })
     }