bugfix: PackageSpec needs version (default is "0.1.0") and manifest t…

…emplate references packageSpec not package
neon-bindings · Mar 28, 2024 · 74fe46a · 74fe46a
1 parent 88e8bb7
commit 74fe46a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/pkgs/create-neon/data/templates/manifest/base/default.json.hbs b/pkgs/create-neon/data/templates/manifest/base/default.json.hbs
@@ -1,11 +1,11 @@
 
 {
-  "name": "{{package.name}}",
-  "version": "{{package.version}}",
+  "name": "{{packageSpec.name}}",
+  "version": "{{packageSpec.version}}",
   "main": "index.node",
   "scripts": {},
   "devDependencies": {
-    "@neon-rs/cli": "{{versions.neonCLI}}"{{#eq package.library.lang compare="ts"}},
+    "@neon-rs/cli": "{{versions.neonCLI}}"{{#eq packageSpec.library.lang compare="ts"}},
     "@tsconfig/node{{versions.tsconfigNode.major}}": "^{{versions.tsconfigNode.semver}}",
     "@types/node": "^{{versions.typesNode}}",
     "typescript": "^{{versions.typescript}}"{{/eq}}

diff --git a/pkgs/create-neon/data/templates/manifest/base/library.json.hbs b/pkgs/create-neon/data/templates/manifest/base/library.json.hbs
@@ -1,7 +1,7 @@
 
 {
-  "name": "{{package.name}}",
-  "version": "{{package.version}}",
+  "name": "{{packageSpec.name}}",
+  "version": "{{packageSpec.version}}",
 {{#eq packageSpec.library.module compare="esm"}}
   "exports": {
     ".": {

diff --git a/pkgs/create-neon/src/index.ts b/pkgs/create-neon/src/index.ts
@@ -22,6 +22,7 @@ export type CreateNeonOptions = {
 export async function createNeon(name: string, options: CreateNeonOptions) {
   const packageSpec: PackageSpec = {
     name,
+    version: "0.1.0",
     library: options.library,
     yes: options.yes,
   };

diff --git a/pkgs/create-neon/src/package.ts b/pkgs/create-neon/src/package.ts
@@ -39,6 +39,7 @@ export type LibrarySpec = {
 
 export type PackageSpec = {
   name: string;
+  version: string;
   library: LibrarySpec | null;
   cache?: Cache | undefined;
   ci?: CI | undefined;