Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow presets in manifest #15

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Allow presets in manifest #15

merged 1 commit into from
Nov 26, 2023

Conversation

dherman
Copy link
Collaborator

@dherman dherman commented Nov 26, 2023

Allow target family presets in package.json (under neon.targets):

  • neon rust-target recognizes presets in the manifest and knows how to expand them based on the FAMILY.json database
  • neon add-target no longer automatically expands the preset in the manifest (if it doesn’t have to), allowing for more readable manifests
  • integration test sniff-bytes uses presets in the manifest for testing

Example:

  "neon": {
    "type": "source",
    "org": "@sniff-bytes",
    "targets": [
      "linux",
      "macos"
    ]
  }

- `neon rust-target` recognizes presets in the manifest and knows how to expand them based on the FAMILY.json database
- `neon add-target` no longer automatically expands the preset in the manifest, allowing for more readable manifests
- integration test `sniff-bytes` uses presets in the manifest for testing
@dherman dherman marked this pull request as ready for review November 26, 2023 20:18
@dherman dherman merged commit e827817 into main Nov 26, 2023
2 checks passed
@dherman dherman deleted the allow-presets-in-manifest branch November 26, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant