Target family presets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 23, 2023 00:00
- family.json is the database of presets - add-target help info describes the presets - `neon add-target` can take a present e.g. `neon add-target linux` - we won't yet change the `"targets"` section format but we'll get ready to in the future: * `neon tarball` in the future won't ever take a --target and create a temp dir, it'll require `--in-dir` * so for now let's add `neon rust-target` to do the node2rust conversion for a project, and we'll use that in neon-actions/build in a future iteration * to be ready for that, this repo will always use `--in-dir` instead of `--target` * in the next commit in this PR, let's make `neon add-target` create the template package directory for a target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new target family presets to
add-targetcommand:neon add-targetcan take a preset, e.g.neon add-target linux"targets"section format but we'll get ready to in the future:neon add-targetcreates the template package directory for a targetneon tarballin the future won't ever take a--targetand create a temp dir, it'll require--in-dirneon rust-targetto do the node2rust conversion for a project, and we'll use that in neon-actions/build in a future iteration--in-dirinstead of--targetneon add-targetcreates the template package directory for a target