Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: move search bar into the header #154

Closed
wants to merge 7 commits into from
Closed

Conversation

fuentesloic
Copy link
Member

No description provided.

@@ -0,0 +1,16 @@
url = window.location.href
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be interested into the following magic:

const query = window.location.search.slice(1).split('&').map(kv => kv.split('=')).map(arr => [arr[0], unescape(arr[1])])
const q = query.get('q')

Array.from(document.querySelectorAll('#search input')).forEach(input => {
  input.value = q
})

@fuentesloic
Copy link
Member Author

fuentesloic commented Aug 14, 2017

capture d ecran 2017-08-14 a 16 14 52-fullpage

@vinyll
Copy link
Member

vinyll commented Aug 14, 2017

I'd rather imagine something more discreet and incrusted, such as:

search example

@AymericFaivre / @newick: opinions or suggestions?

@AymericFaivre
Copy link
Contributor

Hey !

Yep, maybe just put the magnifying glass on the top left, and deploy the form on click. Maybe with just the glass in green. (like on medium, I like this kind of interaction)

Or put the first or second @vinyll's example to the top left and skin it by putting the magnifying glass in green and the border radius at max.

@newick
Copy link
Contributor

newick commented Aug 16, 2017

I agree with @AymericFaivre for the interaction and the rest :D

@fuentesloic fuentesloic changed the title move search bar into the header WIP: move search bar into the header Aug 18, 2017
@fuentesloic
Copy link
Member Author

following the issue #39
So for now, not enought content

@vinyll
Copy link
Member

vinyll commented Aug 20, 2017

According to #39 (comment), this PR is being postponed.

@fuentesloic fuentesloic deleted the header-search branch March 20, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants