-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: move search bar into the header #154
Conversation
static/js/search.js
Outdated
@@ -0,0 +1,16 @@ | |||
url = window.location.href |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be interested into the following magic:
const query = window.location.search.slice(1).split('&').map(kv => kv.split('=')).map(arr => [arr[0], unescape(arr[1])])
const q = query.get('q')
Array.from(document.querySelectorAll('#search input')).forEach(input => {
input.value = q
})
I'd rather imagine something more discreet and incrusted, such as: @AymericFaivre / @newick: opinions or suggestions? |
Hey ! Yep, maybe just put the magnifying glass on the top left, and deploy the form on click. Maybe with just the glass in green. (like on medium, I like this kind of interaction) Or put the first or second @vinyll's example to the top left and skin it by putting the magnifying glass in green and the border radius at max. |
I agree with @AymericFaivre for the interaction and the rest :D |
following the issue #39 |
According to #39 (comment), this PR is being postponed. |
No description provided.