Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Configuration to model the additional dependencies of each run #81

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Dec 17, 2023

Use a Configuration to model the additional dependencies of each run, since configurations seem to be better at tracking task dependencies.

This does change syntax insofar as adding configurations will now look different.

It'll just be

runtime <configuration>

instead of

runtime configuration(<configuration>)

This is due to extending the internal configuration from the given configuration, and not converting the configuration into a Dependency first.

What could be discussed: Should the configuration be transitive by default? I think it should be, since that's how the normal runtime configuration would behave.

… since configurations seem to be better at tracking task dependencies.
@shartte shartte marked this pull request as ready for review December 18, 2023 12:17
@marchermans marchermans merged commit 7e4bb9a into neoforged:NG_7.0 Dec 18, 2023
3 checks passed
@shartte shartte deleted the fix-dep branch December 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants