Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform decompile step into a task that is customizable via specific settings #46

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 11, 2023

TODO

  • Convention the properties to Gradle properties so they're easy to set via gradle.properties (e.g. neogradle.subsystems.decompiler.maxMemory=4g)

Example:

subsystems {
  decompiler {
    maxMemory = "2g"
    maxThreads = 4
    logLevel = DecompilerLogLevel.TRACE
    jvmArgs = ["-verbose:gc']
  }
}

@shartte shartte marked this pull request as ready for review November 24, 2023 23:16
@shartte
Copy link
Contributor Author

shartte commented Nov 24, 2023

@marchermans Added the property binding and at least added some docs to README.md about them, otherwise we'll surely forget to ever document them 😓

@shartte shartte force-pushed the decompiler-settings branch from 5a8e919 to e5ec2a1 Compare November 29, 2023 21:29
@shartte shartte requested a review from Matyrobbrt November 29, 2023 21:30
README.md Outdated
our official [Documentation](https://docs.neoforged.net/neogradle/docs/).

To see the latest available version of NeoGradle, visit
the [NeoForged Maven](https://maven.neoforged.net/#/releases/net/neoforged/gradle/userdev).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to https://projects.neoforged.net/neoforged/neogradle as it provides copy buttons.

@shartte shartte force-pushed the decompiler-settings branch from d99e517 to 07f75a0 Compare November 30, 2023 21:38
@Matyrobbrt Matyrobbrt merged commit d09a284 into neoforged:NG_7.0 Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants