-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform decompile step into a task that is customizable via specific settings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marchermans Added the property binding and at least added some docs to README.md about them, otherwise we'll surely forget to ever document them 😓 |
Matyrobbrt
requested changes
Nov 25, 2023
...mmon/src/main/groovy/net/neoforged/gradle/dsl/common/extensions/subsystems/Decompiler.groovy
Outdated
Show resolved
Hide resolved
common/src/main/java/net/neoforged/gradle/common/extensions/subsystems/SubsystemsExtension.java
Outdated
Show resolved
Hide resolved
shartte
force-pushed
the
decompiler-settings
branch
from
November 29, 2023 21:29
5a8e919
to
e5ec2a1
Compare
Matyrobbrt
requested changes
Nov 29, 2023
...mmon/src/main/groovy/net/neoforged/gradle/dsl/common/extensions/subsystems/Decompiler.groovy
Outdated
Show resolved
Hide resolved
...mmon/src/main/groovy/net/neoforged/gradle/dsl/common/extensions/subsystems/Subsystems.groovy
Outdated
Show resolved
Hide resolved
Matyrobbrt
approved these changes
Nov 30, 2023
README.md
Outdated
our official [Documentation](https://docs.neoforged.net/neogradle/docs/). | ||
|
||
To see the latest available version of NeoGradle, visit | ||
the [NeoForged Maven](https://maven.neoforged.net/#/releases/net/neoforged/gradle/userdev). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should link to https://projects.neoforged.net/neoforged/neogradle
as it provides copy buttons.
…ensions/subsystems/Decompiler.groovy Co-authored-by: Matyrobbrt <[email protected]>
…ensions/subsystems/Subsystems.groovy Co-authored-by: Matyrobbrt <[email protected]>
shartte
force-pushed
the
decompiler-settings
branch
from
November 30, 2023 21:38
d99e517
to
07f75a0
Compare
Matyrobbrt
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
neogradle.subsystems.decompiler.maxMemory=4g
)Example: