Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure for PR publishing #429

Merged
merged 7 commits into from
Dec 28, 2023

Conversation

Matyrobbrt
Copy link
Member

@Matyrobbrt Matyrobbrt commented Dec 26, 2023

Adds the ability to publish PRs to GitHub Packages for testing purposes.
The publishing is controlled by a checkbox in a bot comment, which is ticked by default for maintainers, and can be ticked (or unticked) by any maintainer.
In this repository, a MDK will also be generated with a visible installer link in the comment (more information on that can be found here).

An example of this system in action can be found here. I would appreciate some testing of the MDK setup script by people running non-Windows systems.

Questions and more information can be found in the GU PR which this PR depends on.

The dependency on the GU PR is virtual and not functional (it serves the sole purpose of making sure that there won't be differences between the actual workflow in this repository and the template). This PR works and can be reviewed.

For maintainers: leave the merging up to me.

@Matyrobbrt Matyrobbrt added 1.20 Targeted at Minecraft 1.20 ci/build Related to continuous integration/build system labels Dec 26, 2023
@Matyrobbrt Matyrobbrt marked this pull request as ready for review December 27, 2023 14:36
@Matyrobbrt Matyrobbrt self-assigned this Dec 27, 2023
@Matyrobbrt Matyrobbrt requested a review from a team December 27, 2023 14:48
sciwhiz12
sciwhiz12 previously approved these changes Dec 27, 2023
embeddedt
embeddedt previously approved these changes Dec 27, 2023
Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice; it will be extremely useful for testing API reworks before they are officially shipped.

Also, the MDK setup script works on Linux.

XFactHD
XFactHD previously approved these changes Dec 27, 2023
Copy link
Member

@XFactHD XFactHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script provided by the action should mention that the -L option needs to be removed from the curl invocation for it to work in PowerShell on Windows, but other than that :shipit:

@Matyrobbrt Matyrobbrt dismissed stale reviews from XFactHD, embeddedt, and sciwhiz12 via 2c73399 December 27, 2023 19:20
@Matyrobbrt Matyrobbrt merged commit 1360014 into neoforged:1.20.x Dec 28, 2023
3 checks passed
@Matyrobbrt Matyrobbrt deleted the pr-publishing branch December 28, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Targeted at Minecraft 1.20 ci/build Related to continuous integration/build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants