-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure for PR publishing #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice; it will be extremely useful for testing API reworks before they are officially shipped.
Also, the MDK setup script works on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script provided by the action should mention that the -L
option needs to be removed from the curl
invocation for it to work in PowerShell on Windows, but other than that
2c73399
Adds the ability to publish PRs to GitHub Packages for testing purposes.
The publishing is controlled by a checkbox in a bot comment, which is ticked by default for maintainers, and can be ticked (or unticked) by any maintainer.
In this repository, a MDK will also be generated with a visible installer link in the comment (more information on that can be found here).
An example of this system in action can be found here. I would appreciate some testing of the MDK setup script by people running non-Windows systems.
Questions and more information can be found in the GU PR which this PR depends on.
The dependency on the GU PR is virtual and not functional (it serves the sole purpose of making sure that there won't be differences between the actual workflow in this repository and the template). This PR works and can be reviewed.
For maintainers: leave the merging up to me.