Add optiononlyGraphQLEvents for subscriptions
#5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 526b3c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const cdcEvents = await this.cdcApi.queryEvents(this.subscribeToLabels); | ||
| let txFilter: Cypher.Map | undefined; | ||
| if (this.filterGraphQLEvents) { | ||
| const app = `${environment.NPM_PACKAGE_NAME}@${environment.NPM_PACKAGE_VERSION}`; |
There was a problem hiding this comment.
This is a value used elsewhere, so we should have it as a constant somewhere to ensure these don't fall out of sync.
|
|
||
| constructor({ | ||
| driver, | ||
| pollTime = 1000, | ||
| queryConfig, | ||
| filterGraphQLEvents = false, |
There was a problem hiding this comment.
I think this nomenclature is awkward - when this is true it... Filters out GraphQL events?
onlyGraphQLEvents?
darrellwarde
previously approved these changes
Nov 25, 2024
angrykoala
dismissed
darrellwarde’s stale review
The base branch was changed.
angrykoala
deleted the
5787-neo4jgraphqlsubscriptionscdcengine-with-enabled-cdcaura-kills-the-neo4j-graphql-server-whenever-massive-data-changes-happen-within-a-short-period-of-time
branch
darrellwarde
changed the title
onlyGraphQLEvents for subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the option
filterGraphQLEventsto only trigger CDC on GraphQL events