Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter cdc events skipping nodes not present in the schema #5834

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

angrykoala
Copy link
Member

Description

CDC subscription optimization. Only node events with labels present in the GraphQL schema will be queried. This will reduce the number of subscription events queried by skipping events to nodes that cannot be subscribed through GraphQL

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 67f915e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have some tests for this perhaps?

@angrykoala
Copy link
Member Author

I'm not sure if this is really testable without lots of mocks, as it has to be tested e2e (using a real database) but the external behaviour of a service running this hasn't changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants