Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate 4667 tests to use old tooling #5184

Merged
merged 2 commits into from
May 30, 2024
Merged

Migrate 4667 tests to use old tooling #5184

merged 2 commits into from
May 30, 2024

Conversation

MacondoExpress
Copy link
Contributor

as title.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36b1d65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

darrellwarde
darrellwarde approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just get rid of the additional code block "decorator"!

packages/graphql/tests/tck/issues/4667.test.ts Outdated Show resolved Hide resolved
@MacondoExpress MacondoExpress merged commit 1dfe40d into neo4j:4.x May 30, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darrellwarde darrellwarde darrellwarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Triage
Status: Pull requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MacondoExpress @darrellwarde