-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve
]: use IReadOnlyStoreView
instead.
#3683
base: master
Are you sure you want to change the base?
Conversation
I think the name is still misleading,,, and confusing, storeview,,, snapshot,,,, datacache,,,, |
@shargon maybe you can have a pr to standardize the class/param names |
The name “StoreView” already exists, and no new things have been added. |
Just note that, |
I think it's better to separate read-only APIs as an interface(for example, there are already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require testing to ensure that both types are detected by the native contract calls
@Jim8y
|
Description
Using
IReadOnlyStoreView
instead ofDataCache
to make the semantics clearer in some read-only cases.Fixes # (issue)
Type of change
Checklist: