-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blame tests #3662
base: master
Are you sure you want to change the base?
Remove blame tests #3662
Conversation
Why what's the reason, description doesn't say anything. I just used it to help me figure out why a test failed. |
|
||
- name: Test (windows) | ||
if: matrix.os == 'windows-latest' | ||
run: | | ||
dotnet sln neo.sln remove ./tests/Neo.Plugins.Storage.Tests/Neo.Plugins.Storage.Tests.csproj | ||
dotnet build | ||
dotnet test --blame-hang --blame-crash --no-build | ||
dotnet test --no-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still need this, i would like to know the reasons why dotnet hangs or crashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need to know the test who fail, with blame is slower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but you remember that github actions would hang for a very long time for no reason, thats why we added the --blame-hang
same for --blame-crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this problem appears, we can enable it again, now is waste of time
Description
Not required now
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: