Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compression by p2p #3655

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Disable compression by p2p #3655

wants to merge 7 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 8, 2025

Description

Step 1 of #2626, add node capability for disable compression

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a configuration to disable local compression immediately, this is backwards-compatible (and make it send the new attribute in the subsequent version).

@shargon shargon changed the title Disable compression - Step 1 Disable compression by p2p Jan 8, 2025
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your missing ProtocolSettings.

@shargon
Copy link
Member Author

shargon commented Jan 9, 2025

Your missing ProtocolSettings.

Where?

@@ -209,9 +209,14 @@ private void OnStartProtocol()
new FullNodeCapability(NativeContract.Ledger.CurrentIndex(system.StoreView))
};

if (!localNode.EnableCompression)
{
capabilities.Add(new DisableCompressionCapability());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit aggressive (will break in mixed node scenario), but likely not a problem in real life (old versions to be phased out quickly after HF and this attribute is not expected to be used often).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants