Ext PRs test 1: inside .github/ #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjaglumac
pushed a commit
that referenced
this pull request
Nov 13, 2023
…ions to dashboards in public collections (metabase#35135) * Prepare to consolidate variables * Hide personal collections in question picker (metabase#35136) * Only shows public collections when adding questions to a dashboard in public collection * Fix dashboard crashing when updating * Address review * Fix type error * Fix conflicts between FE's generated `is_personal` and BE's * Hide public collections in dashboard picker (metabase#35137) * Fix typo * Hides public collections in DashboardPicker When selecting a dashboard for a question in personal collection * Fix not calling `useCollectionQuery` unnecessarily Eventhough in this case it won't make any difference, because `useCollectionQuery` is cached, we still shouldn't do that. * Handle recently viewed dashboard * Refactor default import and fix respective tests * Refactor moving files closer to their usage * Hide create a new dashboard option When the question is in a personal collection and is opening public collection in the dashboard picker. This only happens when users are opening the root collection as other public collections won't be visible. * Hide items in ItemPicker When the question is in personal collection and users are opening a public collection. This only happens when users are opening the root collection because other public collections are not visible. * Make the boolean more readable * Remove unused export * Fix failed unit tests * Avoid circular dependency * Simplify dashboard collection type * Simplify selectors * Address review: improves hook name * Review: Avoid using `ComponentProps` * Review: Avoid using `useEffect` to call callback * Fix dashboard picker for private questions not searching * Review: convert a hook without hook usage to function * Negate the boolean to positive name to make it easier to read * Remove unrelated import and matches card to dashboard API types * Handle moving dashboards to a different collection type (metabase#35138) * Fix typo * Hides public collections in DashboardPicker When selecting a dashboard for a question in personal collection * Fix not calling `useCollectionQuery` unnecessarily Eventhough in this case it won't make any difference, because `useCollectionQuery` is cached, we still shouldn't do that. * Handle recently viewed dashboard * Refactor default import and fix respective tests * Refactor moving files closer to their usage * Hide create a new dashboard option When the question is in a personal collection and is opening public collection in the dashboard picker. This only happens when users are opening the root collection as other public collections won't be visible. * Hide items in ItemPicker When the question is in personal collection and users are opening a public collection. This only happens when users are opening the root collection because other public collections are not visible. * Make the boolean more readable * Remove unused export * Fix failed unit tests * Avoid circular dependency * Simplify dashboard collection type * Simplify selectors * Address review: improves hook name * Review: Avoid using `ComponentProps` * Review: Avoid using `useEffect` to call callback * Fix dashboard picker for private questions not searching * Review: convert a hook without hook usage to function * Negate the boolean to positive name to make it easier to read * Remove unrelated import and matches card to dashboard API types * Handle moving dashboards to a different collection type Move between personal/public collections * Add dashboard picker tests (metabase#35141) * Fix removing FE key since BE key is hydrated * Add some basic tests * Add more test cases * Add test #1, and #2 * Modify setup argument to prepare for new tests * Completed the unit tests * Removed comments used during development * Revert test util changes because I don't need it * Make asserting breadcrumbs easier to read * remove outdated comment * Make test code cleaner * add missing unit tests * Prepare to add unit tests * Fix conflict from master * Add question picker tests (metabase#35142) * Fix removing FE key since BE key is hydrated * Add some basic tests * Add more test cases * Add test #1, and #2 * Modify setup argument to prepare for new tests * Completed the unit tests * Removed comments used during development * Revert test util changes because I don't need it * Make asserting breadcrumbs easier to read * remove outdated comment * Make test code cleaner * add missing unit tests * Prepare to add unit tests * Fix conflict from master * Add a unit test file * Removes PropType error * Added the rest of the test * Fix type error from upstream change * Add E2E tests (metabase#35171) * Fix removing FE key since BE key is hydrated * Add some basic tests * Add more test cases * Add test #1, and #2 * Modify setup argument to prepare for new tests * Completed the unit tests * Removed comments used during development * Revert test util changes because I don't need it * Make asserting breadcrumbs easier to read * remove outdated comment * Make test code cleaner * add missing unit tests * Prepare to add unit tests * Fix conflict from master * Add a unit test file * Removes PropType error * Added the rest of the test * Fix type error from upstream change * Add E2E test for question picker * Add E2E test for dashboard picker for new questions * Add E2E test for dashboard picker for existing questions * Revert util to fix failed tests * Remove commented code during development * Fix E2E without modifying a shared util * Make E2E tests less prone to flakiness
nemanjaglumac
force-pushed
the
master
branch
from
394f120
to
58e91cb
Compare
nemanjaglumac
force-pushed
the
master
branch
4 times, most recently
from
ac1add3
to
5f890a2
Compare
nemanjaglumac
force-pushed
the
master
branch
3 times, most recently
from
60614f9
to
54d7a3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
If you are merging into master, please add either a
backportor ano-backportlabel to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details.Closes https://github.com/metabase/metabase/issues/[issue_number]
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist