Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [5.x] mixed types & trailing comma #2396

Merged
merged 2 commits into from
Nov 15, 2024
Merged

refactor: [5.x] mixed types & trailing comma #2396

merged 2 commits into from
Nov 15, 2024

Conversation

DjordyKoert
Copy link
Collaborator

@DjordyKoert DjordyKoert commented Nov 15, 2024

Description

Adds mixed php type in code & allows trailing comma's to be used in PHP-CS-Fixer

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (4e94b3a) to head (4be027c).
Report is 1 commits behind head on 5.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              5.x    #2396   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          71       71           
  Lines        2577     2577           
=======================================
  Hits         2461     2461           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert merged commit 6217051 into 5.x Nov 15, 2024
19 checks passed
@DjordyKoert DjordyKoert deleted the 5.x-types branch November 15, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant