Include TidyBehaviour to ensure we clean up references in editor

Runtime/Navigation/NavigationController.cs

@@ -1,5 +1,6 @@
 using UnityEngine;
 
-public class NavigationController : MonoBehaviour {
-
-}
+namespace VioletUI {
+	public class NavigationController : TidyBehaviour {
+	}
+}

Runtime/Navigation/NavigationScreen.cs

@@ -4,24 +4,27 @@
 using UnityEditor;
 #endif
 
-public class NavigationScreen : MonoBehaviour {
-#if UNITY_EDITOR
-	public static bool IsSavingPrefab;
+namespace VioletUI {
+
+	public class NavigationScreen : TidyBehaviour {
+	#if UNITY_EDITOR
+		public static bool IsSavingPrefab;
 
-	public void StartEditing() {
-		IsSavingPrefab = false;
-		try {
-			PrefabUtility.UnpackPrefabInstance(gameObject, PrefabUnpackMode.OutermostRoot, InteractionMode.AutomatedAction);
-		} catch (ArgumentException e) {
-			UnityEngine.Debug.LogWarning($"VioletUI: Couldn't unpack prefab for {name}. Make sure the NavigationScreen is a prefab. {e}");
+		public void StartEditing() {
+			IsSavingPrefab = false;
+			try {
+				PrefabUtility.UnpackPrefabInstance(gameObject, PrefabUnpackMode.OutermostRoot, InteractionMode.AutomatedAction);
+			} catch (ArgumentException e) {
+				UnityEngine.Debug.LogWarning($"VioletUI: Couldn't unpack prefab for {name}. Make sure the NavigationScreen is a prefab. {e}");
+			}
+			gameObject.SetActive(true);
 		}
-		gameObject.SetActive(true);
-	}
 
-	public void StopEditing() {
-		IsSavingPrefab = true;
-		PrefabUtility.SaveAsPrefabAssetAndConnect(gameObject, $"Assets/Implementation/Menus/{name}.prefab", InteractionMode.AutomatedAction);
-		gameObject.SetActive(false);
+		public void StopEditing() {
+			IsSavingPrefab = true;
+			PrefabUtility.SaveAsPrefabAssetAndConnect(gameObject, $"Assets/Implementation/Menus/{name}.prefab", InteractionMode.AutomatedAction);
+			gameObject.SetActive(false);
+		}
+	#endif
 	}
-#endif
 }

Runtime/PrefabApplier.cs

@@ -15,49 +15,52 @@
 /// It does this by hooking into the scene save event, so when the designer saves the scene
 /// all the prefab overrides will be automatically applied.
 /// </summary>
-[ExecuteAlways]
-public class PrefabApplier : MonoBehaviour {
-	void OnDestroy() {
-		EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
-	}
-
-	// tried this in Awake and OnDestroy but apparently these get blown away
-	// when the project recompiles sooo why not here!
-	void Update() {
-		EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
-		EditorSceneManager.sceneSaved += EditorSceneManager_sceneSaved;
-	}
+namespace VioletUI {
 
-	bool isAutosaving = false;
+	[ExecuteAlways]
+	public class PrefabApplier : TidyBehaviour {
+		void OnDestroy() {
+			EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
+		}
 
-	void EditorSceneManager_sceneSaved(Scene scene) {
-		if (Application.isPlaying) { return; }
-		if (isAutosaving) {
-			isAutosaving = false;
-			return;
+		// tried this in Awake and OnDestroy but apparently these get blown away
+		// when the project recompiles sooo why not here!
+		void Update() {
+			EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
+			EditorSceneManager.sceneSaved += EditorSceneManager_sceneSaved;
 		}
-		UpdatePrefabs();
-	}
 
-	[Button, GUIColor(0.898f, 0.745f, 0.935f)]
-	public void UpdatePrefabs() {
-		bool hasChanges = false;
-		foreach (Transform child in transform) {
-			if (PrefabUtility.HasPrefabInstanceAnyOverrides(child.gameObject, false)) {
-				PrefabUtility.ApplyPrefabInstance(child.gameObject, InteractionMode.AutomatedAction);
-				hasChanges = true;
+		bool isAutosaving = false;
+
+		void EditorSceneManager_sceneSaved(Scene scene) {
+			if (Application.isPlaying) { return; }
+			if (isAutosaving) {
+				isAutosaving = false;
+				return;
 			}
+			UpdatePrefabs();
 		}
-		if (!hasChanges) { return; }
+
+		[Button, GUIColor(0.898f, 0.745f, 0.935f)]
+		public void UpdatePrefabs() {
+			bool hasChanges = false;
+			foreach (Transform child in transform) {
+				if (PrefabUtility.HasPrefabInstanceAnyOverrides(child.gameObject, false)) {
+					PrefabUtility.ApplyPrefabInstance(child.gameObject, InteractionMode.AutomatedAction);
+					hasChanges = true;
+				}
+			}
+			if (!hasChanges) { return; }
 
 
-		var scene = SceneManager.GetActiveScene();
-		EditorSceneManager.MarkSceneDirty(scene);
-		isAutosaving = true;
-		EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
-		EditorSceneManager.SaveScene(scene);
-		EditorSceneManager.sceneSaved += EditorSceneManager_sceneSaved;
-		isAutosaving = false;
+			var scene = SceneManager.GetActiveScene();
+			EditorSceneManager.MarkSceneDirty(scene);
+			isAutosaving = true;
+			EditorSceneManager.sceneSaved -= EditorSceneManager_sceneSaved;
+			EditorSceneManager.SaveScene(scene);
+			EditorSceneManager.sceneSaved += EditorSceneManager_sceneSaved;
+			isAutosaving = false;
+		}
 	}
-}
-#endif
+	#endif
+}

Runtime/TidyBehaviour.cs

@@ -0,0 +1,46 @@
+using System.Collections;
+using System.Collections.Generic;
+using UnityEngine;
+using System;
+using System.Diagnostics;
+using System.Reflection;
+
+namespace VioletUI {
+
+	public class TidyBehaviour : MonoBehaviour {
+		protected virtual void OnDestroy() {
+			ReleaseReferences();
+		}
+
+		[Conditional("UNITY_EDITOR")]
+		void ReleaseReferences() {
+			foreach (FieldInfo field in this.GetType().GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)) {
+				Type fieldType = field.FieldType;
+
+				if (typeof(IList).IsAssignableFrom(fieldType)) {
+					IList list = field.GetValue(this) as IList;
+					list?.Clear();
+				} else if (typeof(IDictionary).IsAssignableFrom(fieldType)) {
+					IDictionary dictionary = field.GetValue(this) as IDictionary;
+					dictionary?.Clear();
+				}
+
+				if (!fieldType.IsPrimitive) {
+					field.SetValue(this, null);
+				}
+			}
+
+			foreach (PropertyInfo property in this.GetType().GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)) {
+				Type fieldType = property.PropertyType;
+
+				if (typeof(IList).IsAssignableFrom(fieldType)) {
+					IList list = property.GetValue(this) as IList;
+					list?.Clear();
+				} else if (typeof(IDictionary).IsAssignableFrom(fieldType)) {
+					IDictionary dictionary = property.GetValue(this) as IDictionary;
+					dictionary?.Clear();
+				}
+			}
+		}
+	}
+}

Runtime/Views/View.cs

@@ -4,7 +4,7 @@
 
 namespace VioletUI {
 	[ExecuteAlways]
-	public abstract class View<TState> : MonoBehaviour, IView<TState> where TState : IState {
+	public abstract class View<TState> : TidyBehaviour, IView<TState> where TState : IState {
 		public abstract TState State { get; }
 		public abstract TState LastState { get; }
 		[NonSerialized] public int Index;