Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo, Update RDS Engine Version, and Enable Encryption by Default #1809

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KennyDizi
Copy link

@KennyDizi KennyDizi commented Feb 7, 2024

Type

Bug fix, Enhancement


Description

  • Corrected a typo in the variable name (rdsClusterarn to rdsClusterArn) to improve code readability and consistency.
  • Updated the Aurora MySQL engine version to VER_2_07_9 to use a more recent, non-deprecated version.
  • Enabled storageEncrypted by default for new RDS clusters to enhance security.

Changes walkthrough

Relevant files
Enhancement
index.ts
Fix Typo, Update Default Engine Version, and Enable Encryption by
Default

src/index.ts

  • Corrected variable name from rdsClusterarn to rdsClusterArn to fix a
    typo.
  • Updated the default Aurora MySQL engine version to VER_2_07_9.
  • Ensured storageEncrypted is enabled by default for the RDS cluster.
  • @KennyDizi KennyDizi changed the title [Fix] storageEncrypted by the default Fix Typo, Update RDS Engine Version, and Enable Encryption by Default Feb 7, 2024
    @KennyDizi KennyDizi changed the title Fix Typo, Update RDS Engine Version, and Enable Encryption by Default fix: Typo, Update RDS Engine Version, and Enable Encryption by Default Feb 7, 2024
    Copy link

    gitguardian bot commented Feb 7, 2024

    ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

    Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

    🔎 Detected hardcoded secret in your pull request
    GitGuardian id GitGuardian status Secret Commit Filename
    - Username Password d531d3d test/global-rds.test.ts View secret
    🛠 Guidelines to remediate hardcoded secrets
    1. Understand the implications of revoking this secret by investigating where it is used in your code.
    2. Replace and store your secret safely. Learn here the best practices.
    3. Revoke and rotate this secret.
    4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

    To avoid such incidents in the future consider


    🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

    Our GitHub checks need improvements? Share your feedbacks!

    @KennyDizi
    Copy link
    Author

    @neilkuan Could you take a look at this PR?

    @neilkuan
    Copy link
    Owner

    neilkuan commented Feb 7, 2024

    Hi @KennyDizi
    Please run yarn build at local.
    And commit API.md file. Thanks

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants