Skip to content

Commit

Permalink
Merge pull request #72 from neighborhoods/switch_to_rivet
Browse files Browse the repository at this point in the history
Switching to rivet, going open-source officially
  • Loading branch information
George Wood authored Sep 2, 2021
2 parents 460a8ce + ede3790 commit 44b2e6d
Show file tree
Hide file tree
Showing 15 changed files with 501 additions and 457 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.7.1] 2021-09-02

### Changed
- Switched from `river` to open-source `rivet`

## [1.6.4] 2021-08-05

### Added
Expand Down
2 changes: 1 addition & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pandas = ">=0.25.3"
pandas-gbq = "~=0.14"
pandavro = "~=1.6"
pyhive = {extras = ["hive", "presto"], version = "~=0.6.1"}
river = {version="~=1.5", index="nhds"}
rivet = "~=1.6"
simple-salesforce = "~=1.1"

[requires]
Expand Down
919 changes: 480 additions & 439 deletions Pipfile.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,4 @@ maintain awareness of what is being performed behind-the-scenes. If this
is not desirable (as may be the case for notebooks, pipelines, usage of
`honeycomb` within other packages, etc.), all non-logging output can be
disabled with `hc.set_option('verbose', False)`. This also sets the
corresponding `verbose` option in `river` to False.
corresponding `verbose` option in `rivet` to False.
2 changes: 1 addition & 1 deletion honeycomb/__danger.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from honeycomb import hive, meta

import river as rv
import rivet as rv


def __nuke_table(table_name, schema):
Expand Down
2 changes: 1 addition & 1 deletion honeycomb/_version.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
__title__ = "honeycomb"
__description__ = "Multi-source/engine querying tool"
__url__ = "https://github.com/neighborhoods/honeycomb"
__version__ = "1.6.4"
__version__ = "1.7.1"
__author__ = "George Wood (@Geoiv)"
__author_email__ = "[email protected]"
2 changes: 1 addition & 1 deletion honeycomb/append_table.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import river as rv
import rivet as rv

from honeycomb import check, meta, dtype_mapping
from honeycomb.alter_table import add_partition
Expand Down
2 changes: 1 addition & 1 deletion honeycomb/config.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import river as rv
import rivet as rv

_options = {
'verbose': True
Expand Down
4 changes: 2 additions & 2 deletions honeycomb/create_table/build_and_run_ddl_stmt.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import river as rv
import rivet as rv

from honeycomb import hive, meta
from honeycomb.alter_table import add_partition
Expand Down Expand Up @@ -51,7 +51,7 @@ def build_and_run_ddl_stmt(df, table_name, schema, col_defs,
Schema to use when writing a DataFrame to an Avro file. If not
provided, one will be auto-generated.
"""
# Gets settings to pass to river on how to write the files in a
# Gets settings to pass to rivet on how to write the files in a
# Hive-readable format
storage_settings = meta.storage_type_specs[storage_type]['settings']

Expand Down
2 changes: 1 addition & 1 deletion honeycomb/create_table/create_table_from_df.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import logging
import sys

import river as rv
import rivet as rv

from honeycomb import meta
from honeycomb.create_table.build_and_run_ddl_stmt import (
Expand Down
4 changes: 2 additions & 2 deletions honeycomb/create_table/flash_update_table_from_df.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os

import river as rv
import rivet as rv

from honeycomb import check, hive, meta
from honeycomb.create_table.common import (
Expand Down Expand Up @@ -90,7 +90,7 @@ def flash_update_table_from_df(df, table_name, schema=None, dtypes=None,
df, col_defs = prep_df_and_col_defs(
df, dtypes, timezones, schema, storage_type)

# Gets settings to pass to river on how to write the files in a
# Gets settings to pass to rivet on how to write the files in a
# Hive-readable format
storage_settings = meta.storage_type_specs[storage_type]['settings']

Expand Down
2 changes: 1 addition & 1 deletion honeycomb/meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
'json': {
# Hive expects JSON data to be written differently than df.to_json()
# writes it by default. This is handled by river.
# writes it by default. This is handled by rivet.
'settings': {'hive_format': True},
'ddl': ("ROW FORMAT SERDE\n"
"'org.apache.hadoop.hive.serde2.JsonSerDe'\n"
Expand Down
6 changes: 2 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ def run(self):
sys.executable))

self.status('Uploading the package to PyPI via Twine…')
returned_error = os.system(
'twine upload dist/* '
'--repository-url http://pypi.neighborhoods.com/simple/')
returned_error = os.system('twine upload dist/* ')
if returned_error:
raise ValueError('Pushing to PyPi failed.')

Expand Down Expand Up @@ -86,7 +84,7 @@ def run(self):
install_requires=[
'pandas>=0.25.3',
'pyhive[hive, presto]>=0.6.1',
'river>=1.5', # Stored in nhds PyPi
'rivet>=1.6',
'pandavro>=1.6'
],
extras_require={
Expand Down
2 changes: 1 addition & 1 deletion test/test_append_table.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

import river as rv
import rivet as rv

from honeycomb import append_df_to_table

Expand Down
2 changes: 1 addition & 1 deletion test/test_create_table.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

import river as rv
import rivet as rv

from honeycomb.create_table.create_table_from_df import create_table_from_df

Expand Down

0 comments on commit 44b2e6d

Please sign in to comment.