Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make footer even prettier Issue #672 #765

Merged
merged 20 commits into from
Jul 24, 2020

Conversation

r-s-rai
Copy link
Collaborator

@r-s-rai r-s-rai commented Jul 23, 2020

Related issues and PRs

Fixes issue #672
Related to issues #660 and #669

Description

More aesthetic footer with links to version string as well as to services that power the application

Impacted Areas in the application

This primarily affects the footer.

Testing

Take a look and see for yourself if it looks good. You may need to add "react-tooltip" if the page will not load. We added it as a dependency in package.json but in case it doesn't add it automatically make sure to manually install it with npm.

@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/hixd2va9s
✅ Preview: https://covid19-scenarios-git-fork-437su20-c-r-n-footer.neherlab.vercel.app

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 32781 lines exceeds the maximum allowed for the inline comments feature.

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jul 23, 2020

@r-s-rai Thanks! That's a good start.

Could we:

  • replace png images with svg where possible, for additional crispness

  • use this Vercel image: https://raw.githubusercontent.com/neherlab/webclades/master/packages/web/src/assets/img/powered-by-vercel.svg

  • use this Vercel URL (with analytics tag. It's a part of our deal with them):
    https://vercel.com/?utm_source=nextstrain

  • use <LinkExternal/> component instead of plain <a/> tag (this component opens links in the new tab, to not loose the user's focus, plus has a couple of security-related attributes). This component can accept the same attributes as plain anchor tag.

  • simply use title attribute for tooltips (and remove new dependencies)

  • add alt attributes for accessibility text description

  • remove package-lock.json (we use yarn and yarn.lock, not npm)

  • merge upstream master (not local master) into your branch, so that GitHub shows a sensible diff. Resolve merge conflicts along the way.

?

Don't forget to run yarn eslint for static analysis! The result should be clean in order to production build to pass.

@vercel vercel bot temporarily deployed to Preview July 23, 2020 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview July 24, 2020 01:38 Inactive
@codeclimate
Copy link

codeclimate bot commented Jul 24, 2020

Code Climate has analyzed commit ad4d561 and detected 0 issues on this pull request.

View more on Code Climate.

@ivan-aksamentov
Copy link
Member

@r-s-rai This is indeed very pretty. Great job! Thanks a ton! 🎉

@ivan-aksamentov ivan-aksamentov merged commit 2e0e202 into neherlab:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants