Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add currency information and local names to country list #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdullahceylan
Copy link

This PR enhances the country list by adding comprehensive currency information and local names for all countries. The additions include:

Changes Made

  • Updated CountryInterface type to include new optional fields:

    • currency?: string - Full currency name
    • currency_code?: string - ISO 4217 currency code
    • currency_symbol?: string - Currency symbol
  • Added currency information for all countries

  • Fixed corrupted flag emojis for several countries

  • Updated local names to be more accurate and include native scripts

  • Standardized currency symbol formats

Sources

@Skarvion
Copy link
Contributor

I'm not the maintainer, but looking at this, there are few feedbacks:

Cheers for the PR!

@necessarylion
Copy link
Owner

Thanks a bunch for the PR! It looks great to me.

By the way, could you please add the newly added keys function to the src/country.ts file?

Also, make sure you have a cover test case for it. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants