Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing deps and update babel config to comply with updated storybook requirements #415

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ergusto
Copy link
Member

@ergusto ergusto commented Apr 3, 2024

Fixes #414

These missing dependencies were causing Quantum release pipelines to fail. Also updated the babel config as was seeing some errors locally. Once deployed the update to Storybook 8 should resolve the errors showing on prod.

Note: project had previously been updated to Storybook 8 but a successful deployment hadn't been run since then due to these issues.

Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for quantum-deploy-previews ready!

Name Link
🔨 Latest commit e682af3
🔍 Latest deploy log https://app.netlify.com/sites/quantum-deploy-previews/deploys/660d5fe688bcf70009238608
😎 Deploy Preview https://deploy-preview-415--quantum-deploy-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ergusto ergusto requested a review from simoneb April 3, 2024 13:57
@simoneb
Copy link
Member

simoneb commented Apr 3, 2024

Thanks for this @ergusto . This regression popped up several times already, do you think it's possible somehow to prevent this from happening? E.g. is there some sort of automated test we could write which guarantees that this doesn't happen again?

@ergusto
Copy link
Member Author

ergusto commented Apr 3, 2024

@simoneb We should be able to set up Storybook's Test Runner as part of our CI pipeline, this would ensure all Stories render without errors. It looks like there are some new features in Storybook 8 to make this worfklow easier too. I'd be happy to look into this further.

@simoneb
Copy link
Member

simoneb commented Apr 3, 2024

@ergusto let's do this. let's merge this PR so we fix the issue, then have a more thorough follow up activity (feel free to create an issue if you wish) to solve it once and for all, and possibly upgrade storybook to the latest major.

@ergusto ergusto merged commit 78d14a7 into main Apr 3, 2024
6 of 11 checks passed
@ergusto ergusto deleted the feat/414/storybook-errors branch April 3, 2024 15:06
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook documentation throwing errors
2 participants