Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select console error #348

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: select console error #348

merged 1 commit into from
Feb 9, 2024

Conversation

hizo
Copy link
Contributor

@hizo hizo commented Feb 9, 2024

Apparently scroll area inside Select automatically triggers a console error, more info on that here radix-ui/primitives#2059.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for quantum-deploy-previews ready!

Name Link
🔨 Latest commit 170fe84
🔍 Latest deploy log https://app.netlify.com/sites/quantum-deploy-previews/deploys/65c5f56209cabe0008894a72
😎 Deploy Preview https://deploy-preview-348--quantum-deploy-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 9, 2024

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

<ScrollArea.Viewport className="w-full h-full">
<ScrollArea.Viewport
className="w-full h-full"
style={{ overflowY: 'auto' }}
Copy link
Contributor Author

@hizo hizo Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found this to be working, whereas trying to do the same with a tailwind utility class hasn't worked

@hizo hizo merged commit 3a9849c into main Feb 9, 2024
6 of 8 checks passed
@hizo hizo deleted the fix/select-console-error branch February 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants