Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/127 accordion #227

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Feat/127 accordion #227

merged 6 commits into from
Dec 18, 2023

Conversation

i-suman
Copy link
Contributor

@i-suman i-suman commented Dec 13, 2023

Closes #127

@i-suman i-suman requested a review from nherment December 13, 2023 14:28
Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

@i-suman i-suman self-assigned this Dec 13, 2023
@i-suman i-suman added enhancement New feature or request javascript Pull requests that update Javascript code labels Dec 13, 2023
@i-suman i-suman linked an issue Dec 13, 2023 that may be closed by this pull request
4 tasks
Copy link

@nherment nherment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Some things do not seem to be to spec (see below):

  • There seems to be a line between an unopened section followed by an opened one
  • The horizontal lines stop short of the edges of the component
  • The Dark mode seems to be unimplemented.

image
image

image

@Ademsk1 Ademsk1 dismissed their stale review December 14, 2023 09:26

mistake

Copy link
Contributor

@Ademsk1 Ademsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add this to src/index.js so it can be imported from.

@i-suman
Copy link
Contributor Author

i-suman commented Dec 14, 2023

Looks good and works well. Some things do not seem to be to spec (see below):

  • There seems to be a line between an unopened section followed by an opened one
  • The horizontal lines stop short of the edges of the component
  • The Dark mode seems to be unimplemented.

image image

image

Changes are done

Don't forget to add this to src/index.js so it can be imported from.

Made it available

@i-suman i-suman requested a review from nherment December 14, 2023 12:11
@i-suman i-suman merged commit 22d8f5e into main Dec 18, 2023
3 checks passed
@i-suman i-suman deleted the feat/127-accordion branch December 18, 2023 07:41
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] - Accordion
3 participants