Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react + react dom deps #181

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: remove react + react dom deps #181

merged 1 commit into from
Nov 27, 2023

Conversation

Ademsk1
Copy link
Contributor

@Ademsk1 Ademsk1 commented Nov 27, 2023

Fixes #179

Checked the published dist folder, and it no longer contained the react or react-dom. Components still worked on consumer app, and also on quantums storybook

Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

@Ademsk1 Ademsk1 requested a review from swdilip November 27, 2023 17:35
Copy link
Contributor

@swdilip swdilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏾

@Ademsk1 Ademsk1 merged commit 10b307a into main Nov 27, 2023
5 checks passed
@Ademsk1 Ademsk1 deleted the fix/179-rm-react-deps branch November 27, 2023 17:38
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not export React and other dependencies as part of our bundle
2 participants