Feat/144 oss icons #176
Merged
Feat/144 oss icons #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![review-bot-for-github[bot]](https://avatars.githubusercontent.com/u/1544687?s=60&v=4){kind=small}
|
The icons look great! Some of them are a bit thicker or thinner than the others. Such as Also in
|
|
@swdilip Some icons are meant to be bigger than others, hence the difference in thickness. For dark mode, we allow the user to pass in props to the icons, so that they may alter the colors directly :D |
Ademsk1
force-pushed
the
feat/144_oss_icons
branch
from
56111ee to
0c321f8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
Also I added an mdx file to list out all the icons, renamed every single icon to be more clear, moved over the index file into components so our src index file can be more concise