Fix/recursive import #103
Merged
Fix/recursive import #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Oct 19, 2023
There was a problem hiding this comment.
did you intend to remove the npmignore file?
There was a problem hiding this comment.
@simoneb Yes, I mention it above in the pr comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Fixing the recursive import. Beforehand we were importing the parent module which did not ignore the sample module thereby making many many node modules. I'm instead using a local import.
I decided to not use npmignore, as we have the
filesin package.json which whitelists only thedistfolder so the examples will not be packaged up.