chore: add automatically_derived attribute to derive macros #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentBerthier
requested review from
frol,
dj8yfo,
PolyProgrammist and
akorchyn
as code owners
VincentBerthier
force-pushed
the
auto_derive_attr
branch
from
02ab6f9 to
78a69a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage reports (obtained by cargo-llvm-cov for example) rely on the presence of the
#[automatically_derived]attribute to skip derive macro blocks, however that attribute is missing inborsh’s derive macros.This simply adds the
#[automatically_derived]attribute on top of theimplblocks in the derive macros to fix this little problem.Should have absolutely no impact in the behaviour of the crate other than that.