Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to ember 4 #1

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

ndekeister-us
Copy link
Owner

@ndekeister-us ndekeister-us commented Nov 15, 2022

Breaking

Officially drop support for Node < 12

Drop support for Ember <3.24

Chore

Upgrade to Ember 4

  • run ember-cli-update --to 4.4.0 and yarn install

Also

  • specify node version supported in package.json (>= 12)
  • update ember-classic-decorator devDeps to v3.0.1 (v2 was not compatible with Ember 4)
  • update ember-data devDeps to 4.4.x (v3 was not compatible with Ember 4)
  • run yarn-deduplicate && yarn install to clean the yarn.lock
  • remove jshint config files used in tests (not relevant anymore, was introduced with first versions of Ember, we now use eslint in tests)
  • lint
    • fix some lint errors in test
    • fix template lint errors
    • ⚠️ temporarily move eslint and template lint error to a warning -> Goal of this PR is to make this repo compatible with Ember 4 so that consumers using Ember 4 can use it ; refactoring whole addon to native class / glimmer may introduce some side effects and it seems not a blocking for Ember 4

Remove object-bin export

Taken from mharris717#194 (file no longer exists in ./addon/component) should make embroider happy

Build

Remove ember-decorators from devDeps

It was not used by this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant