test suite with continuous integration #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24
This PR introduces isolation tests written in Go and integration tests written in Python, using the
pyln-testing
framework. A pipeline has been added to run the tests on each push to Github.The tests themselves are not exhaustive, this PR is meant to be the foundation for further work.
The test suite has uncovered a couple bugs that are fixed in this same PR.
bcli defines more options than trustedcoin, and in particular the pyln-testing framework assumes
bitcoin-datadir
exists, though trustedcoin did not have it. It has been added with a warning that it is not used, otherwisepyln-testing
cannot run.estimatefees returns bad estimates on regtest, and an early return has been added with fake fee estimations. This is consistent with what bcli does.