Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite with continuous integration #32

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

1ma
Copy link
Contributor

@1ma 1ma commented Nov 12, 2024

Addresses #24

This PR introduces isolation tests written in Go and integration tests written in Python, using the pyln-testingframework. A pipeline has been added to run the tests on each push to Github.

The tests themselves are not exhaustive, this PR is meant to be the foundation for further work.


The test suite has uncovered a couple bugs that are fixed in this same PR.

  1. bcli defines more options than trustedcoin, and in particular the pyln-testing framework assumes bitcoin-datadir exists, though trustedcoin did not have it. It has been added with a warning that it is not used, otherwise pyln-testing cannot run.

  2. estimatefees returns bad estimates on regtest, and an early return has been added with fake fee estimations. This is consistent with what bcli does.

@1ma 1ma mentioned this pull request Nov 12, 2024
@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 12, 2024

Great, now we have Python in this codebase.

@fiatjaf fiatjaf merged commit d76c4c0 into nbd-wtf:master Nov 12, 2024
@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 12, 2024

Thank you, sir, you are a hero.

@1ma 1ma deleted the test-suite branch November 12, 2024 22:49
@ca-ruz
Copy link

ca-ruz commented Nov 15, 2024

@1ma I ran the integration test locally and it's not actually disabling bcli (so trustedcoin is not running). Curious if you're planning on fleshing this out?

@1ma
Copy link
Contributor Author

1ma commented Nov 15, 2024

Duh, you're right. opts={...} should be options={...}. I used to call get_nodes() instead of get_node(), in that function the argument is called opts.

Can you confirm this also fixes the problem for you before I submit a PR?

@ca-ruz
Copy link

ca-ruz commented Nov 15, 2024

Ahh I see. I already tried it with options={...} and it's still failing. I'm having a similar issue with Sauron. You can take a look at this, it should help out: lightningd/plugins#584 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants