-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated template extensions to align with standard Nautobot UI views. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smk4664
reviewed
Sep 12, 2024
nautobot_device_lifecycle_mgmt/management/commands/generate_app_test_data.py
Outdated
Show resolved
Hide resolved
smk4664
reviewed
Sep 12, 2024
nautobot_device_lifecycle_mgmt/management/commands/generate_app_test_data.py
Outdated
Show resolved
Hide resolved
smk4664
reviewed
Sep 12, 2024
smk4664
reviewed
Sep 12, 2024
nautobot_device_lifecycle_mgmt/management/commands/generate_app_test_data.py
Outdated
Show resolved
Hide resolved
gsnider2195
commented
Sep 12, 2024
nautobot_device_lifecycle_mgmt/management/commands/generate_dlm_test_data.py
Outdated
Show resolved
Hide resolved
smk4664
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! It would be nice to establish; a pattern around Factories and handling multiple apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261
This makes the changes to the template extensions as described in #261 but it also adds the
generate_dlm_test_data
management command, similar to the PR in golden config at nautobot/nautobot-app-golden-config#809. This management command makes it easier to generate basic testing data in a development environment. If desired, I can move this to its own PR.Screenshots
Device View
Before
After
Before
After
Before
After
DeviceType View
Before
After
Before
After