-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v2.11 branch #1698
Open
piotrpio
wants to merge
60
commits into
v2.11-dev
Choose a base branch
from
v2.11-rebase
base: v2.11-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update v2.11 branch #1698
+4,843
−1,536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
The change is needed to properly operate on mirrored object store buckets. By binding stream nats.go does not need to search for stream by subjects (which does not work for mirrors).
When mirroring Object Store, there is a need to setup subject transformations. However, client also needs to bind to the stream to avoid stream lookup, which is both not necessary and expensive, and also does not work with Object Store mirrors. Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Co-authored-by: Paolo TETI <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…#1582) Signed-off-by: Piotr Piotrowski <[email protected]>
[FIXED] micro: Incorrect stopErr used
…1586) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…1601) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…1605) Signed-off-by: Piotr Piotrowski <[email protected]>
Fixes #1579 Signed-off-by: Massimo Costa <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
…failed (#1619) Signed-off-by: Piotr Piotrowski <[email protected]>
…ntly with the StreamConfig one (#1630) Signed-off-by: Mattia Barbisan <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
… after reconnect. (#1643) - `Consume()` and `Messages()` no longer call `ConsumerInfo()` on upon reconnect. - Ordered consumers now reset on each reconnect event. Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…errors during look up (#1654)
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
This fixes an issue where a deadlock could occur when calling `Stop()` or `Drain()` on `ConsumeContext` or `MessagesContext` and then calling `Consume` or `Messages` immediately. Switched to using a type-safe implementation of `sync.Map` for subscriptions map instead of locking the whole consumer state. Additionally, changed the type of atomic flags from `uint32` to `atomic.UInt32` to avoid accidental non-atomic reads/writes. Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]> Co-authored-by: Daniel Mack <[email protected]>
Correct README.md formatting
Signed-off-by: Piotr Piotrowski <[email protected]>
* [FIXED] Change Fetch client timeout to a higher value Signed-off-by: Piotr Piotrowski <[email protected]> * Set the maximum diff on timeouts Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
…ription (#1690) Signed-off-by: Piotr Piotrowski <[email protected]>
…closed/drained (#1691) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
This reverts commit 94c83b7.
Jarema
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…idempotent (#1723) Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski [email protected]