Fix data race on client close

The queue state object needs to be locked when removing a subscriber from the list.
nats-io · Jun 22, 2016 · 6cd1c02 · 6cd1c02
1 parent 7e894db
commit 6cd1c02
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/server/server.go b/server/server.go
@@ -306,7 +306,12 @@ func (ss *subStore) Remove(sub *subState, force bool) {
 
 	// Delete ourselves from the list
 	if qs != nil {
+		// For queue state, we need to lock specifically,
+		// because qs.subs can be modified by findBestQueueSub,
+		// for which we don't have substore lock held.
+		qs.Lock()
 		qs.subs, _ = sub.deleteFromList(qs.subs)
+		qs.Unlock()
 	} else {
 		ss.psubs, _ = sub.deleteFromList(ss.psubs)
 	}