consolidator enhancements: throw exception on delete failure, add working directory as argument #44

dkincaid · 2014-01-31T22:13:30Z

These are a couple of enhancements to the Consolidator.

At the end of the consolidator mapper I added a check on the delete of the source file and throw an exception if the delete fails.
The working directory for the consolidator was hard coded to "/tmp/consolidator". I added the ability to specify a different working directory.

… throwing its own exception.

…ectory to be used instead of the previously hard coded "/tmp/consolidator".

sorenmacbeth · 2014-04-02T05:32:26Z

Thanks. This looks good to merge, I'm just wondering if there are any additional test that might be added in addition to the code changes?

Dave Kincaid added 2 commits January 31, 2014 15:25

Throw an exception from the mapper when the file delete fails without…

7e715eb

… throwing its own exception.

Add an argument to the consolidator to allow specifying a working dir…

76a472a

…ectory to be used instead of the previously hard coded "/tmp/consolidator".

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

consolidator enhancements: throw exception on delete failure, add working directory as argument #44

consolidator enhancements: throw exception on delete failure, add working directory as argument #44

dkincaid commented Jan 31, 2014

sorenmacbeth commented Apr 2, 2014

consolidator enhancements: throw exception on delete failure, add working directory as argument #44

Are you sure you want to change the base?

consolidator enhancements: throw exception on delete failure, add working directory as argument #44

Conversation

dkincaid commented Jan 31, 2014

sorenmacbeth commented Apr 2, 2014