Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRADE-187: Add tests for SAMBAH #116

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Nov 18, 2024

Description

Adds a regression test notebook for the SAMBAH service chain.

Supersedes #93, in order to track references files using git lfs.

Jira Issue ID

TRADE-187

Local Test Steps

Ran notebook tests for UAT environment successfully.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • [N/A] Documentation updated (if needed)

@danielfromearth danielfromearth marked this pull request as ready for review November 18, 2024 21:08
@danielfromearth danielfromearth added the enhancement New feature or request label Nov 18, 2024
@danielfromearth
Copy link
Collaborator Author

danielfromearth commented Nov 18, 2024

@owenlittlejohns, @ank1m,

I've revised the Harmony regression test notebook, and I thiiiink it's good. The tests for UAT are passing.

The tests in PROD don't yet produce the same output as the tests in UAT, however, despite using matching granules. I believe that is because of the difference in versions currently deployed in the environments:

PROD: l2ss-2.11.0, batchee-1.1.0, stitchee-1.2.1, concise-0.9.0
UAT: l2ss-2.12.0rc14, batchee-1.2.0, stitchee-1.5.0, concise-0.10.0rc4

The latest versions in UAT have important changes/features—such as stitchee applying a dataset sorting, which enables consistent results—that the PROD versions don't yet have. Once the latest versions are deployed to PROD, I'd expect the tests to pass for PROD too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant