Fix #2502, #2504, CFE updates needed for generated header compatibility (EDS) #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jphickey
force-pushed
the
fix-2502-2504
branch
from
7d7e598 to
6550f6d
Compare
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-2502-2504
branch
from
6550f6d to
3c64fca
Compare
dzbaker
added
CCB:Provisionally-Approved
and removed
CCB:Ready
jphickey
force-pushed
the
fix-2502-2504
branch
from
3c64fca to
413728b
Compare
|
Updated per CCB review to remove leftover commented-out line |
jphickey
added
CCB:Approved
jphickey
force-pushed
the
fix-2502-2504
branch
3 times, most recently
from
b44feb0 to
9112774
Compare
Corrects cases where CFE symbol names did not exactly match expected conventions.
Update UT dispatch objects to allow invoking handlers based on a table lookup rather than configuring the MsgID + CC in the stubs.
jphickey
force-pushed
the
fix-2502-2504
branch
from
9112774 to
ec04415
Compare
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 31, 2024
*Combines:* cFE equuleus-rc1+dev84 osal equuleus-rc1+dev41 **Includes:** *cFE* - nasa/cFE#2505 *osal* - nasa/osal#1368 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
This was referenced Jan 31, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 31, 2024
*Combines:* cFE equuleus-rc1+dev84 osal equuleus-rc1+dev41 **Includes:** *cFE* - nasa/cFE#2505 *osal* - nasa/osal#1368 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Addresses the listed issues which related to compatibility with the generated header files:
Fixes #2502
Corrects name mismatches / deviations from standard naming conventions
Fixes #2504
Updates Unit Tests to be include a "TABLE_OFFSET" dispatch option which is needed when the entire task pipe function is a stub that uses a dispatch table.
Testing performed
Build and run all tests
Expected behavior changes
Compatibility with generated files/headers.
System(s) tested on
Debian
Additional context
All FSW updates are global name change only, no logic change.
Other updates (in 2504) are only unit test
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.