Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ptc refactor #65

Merged
merged 42 commits into from
Nov 8, 2024
Merged

Ptc refactor #65

merged 42 commits into from
Nov 8, 2024

Conversation

cssprad1
Copy link
Contributor

  • Refactor of PTC architecture
  • Each pipeline has their own pt-lightning or torchgeo lightning module
  • 3d cloud pipeline
  • svtoa pretrain pipeline
  • Single CLI for PTC, call pipeline and dataloader through config.
  • Adding to config for deepspeed customization
  • Each transform goes to its own file
  • Model factory for dynamic building of model (see 3d cloud pipeline)
  • Abstracting datasets (see ShardedDataset)
  • Data modules used when applicable (see 3D cloud)

@cssprad1 cssprad1 self-assigned this Oct 31, 2024
Copy link
Contributor

@jordancaraballo jordancaraballo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking the whole refactor, I am really happy with the current setup. I did not have any problems with the current implementation. We should delete unused functions in the next release. I am good with this.

@cssprad1 cssprad1 merged commit 7fe8753 into develop Nov 8, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants