-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ptc refactor #65
Merged
Merged
Ptc refactor #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cssprad1
commented
Oct 31, 2024
- Refactor of PTC architecture
- Each pipeline has their own pt-lightning or torchgeo lightning module
- 3d cloud pipeline
- svtoa pretrain pipeline
- Single CLI for PTC, call pipeline and dataloader through config.
- Adding to config for deepspeed customization
- Each transform goes to its own file
- Model factory for dynamic building of model (see 3d cloud pipeline)
- Abstracting datasets (see ShardedDataset)
- Data modules used when applicable (see 3D cloud)
add tensorboard
…torch-caney into hackathon_2024
Adding optimizer module and lamb with fusedlamb with deepspeed
Hackathon 2024 cssprad1
Hackaton 2024 jl
jordancaraballo
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking the whole refactor, I am really happy with the current setup. I did not have any problems with the current implementation. We should delete unused functions in the next release. I am good with this.
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.