test: codspeed CI workflow #819
Conversation
tpch/benchmarks/queries_test.py
Outdated
| _ = benchmark(q1, lineitem) | ||
| _ = benchmark(q2, region, nation, supplier, part, partsupp) | ||
| _ = benchmark(q3, customer, lineitem, orders) |
There was a problem hiding this comment.
I am not sure that having multiple benchmarks in a single test is ok 🤔
There was a problem hiding this comment.
You can use parametrize, yes, but you need to create different names for each result.
|
Maybe you did it, but just in case: Don't forget to add Narwhals to CodSpeed (you need admin rights). Even if you were able to previously test your fork. |
Maybe I am missing something, but checking in repo settings, I am able to see it enabled. Adding screenshots:
And then in configure:
From the error message it seems we still need a token? |
|
I don't have access to: repo settings OK. I didn't need a token. Plus it says that the repo has not been enabled. edit: |
|
Your name must be listed as admin or provider admin on "permissions". But not of your fork, the Narwhals organization: 
I stop now, I promise. |
|
I should have enabled it, I will make a commit to trigger all the workflows one more time :) Edit: Nice it works now 🙌🏼🎉 |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
|
@MarcoGorelli I will wait for an opinion before going rogue and implement all the queries 😂 |
|
sure, looks good to me, thanks! |
|
Should this be closed? |
|
Hey @DeaMariaLeon thanks for the ping! Sure I will close this as it is out of sync and wait for #863 to be finished before putting more effort into it |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.