Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Narwhals.dependencies to API reference #791

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

MarcoGorelli
Copy link
Member

I think these can be useful to library devs

As much as we like dataframe-agnostic code, sometimes specialised library paths are necessary, and utils like these can help with that

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 14, 2024
@MarcoGorelli MarcoGorelli force-pushed the narwhals.dependencies branch from c67e3c2 to 57f9726 Compare August 14, 2024 14:02
@MarcoGorelli MarcoGorelli marked this pull request as ready for review August 14, 2024 15:24
- is_modin_dataframe
- is_modin_series
- is_numpy_array
- is_pandas_dataframe
- is_pandas_dataframe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is_pandas_dataframe twice??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks!

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli I know you were waiting for an approval GIF 😂

KittyCatGIF

@MarcoGorelli MarcoGorelli merged commit 3f73eb4 into narwhals-dev:main Aug 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants