ci: add downstream tests for altair + scikit-lego #533
Conversation
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
Shall we consider to run it it both as workflow dispatch (i.e. manual trigger) and dependency of publish to pypi, instead of every PR?
I am not sure if you intend to add scikit-lego as well, but test suite there typically take between 2 and 5 mins
There was a problem hiding this comment.
yeah that might be better
There was a problem hiding this comment.
I am not sure if you intend to add scikit-lego as well
I will take it as a yes 😂
There was a problem hiding this comment.
altair actually takes less than our own tests 😄 I think we might as well keep that on in CI
and for scikit-lego, perhaps some tests these could be marked "slow", and we just skip those here?
There was a problem hiding this comment.
Agree! I think it is enough to run everything without extra dependencies as in our scheduled ci
TL;DR
run: pytest -n auto --disable-warnings --cov=sklego -m "not cvxpy and not formulaic and not umap"
MarcoGorelli
changed the title
|
thanks @FBruzzesi ! this adds a 2-minute job for altair, and a 3-minute one for scikit-lego. for now, I'd suggest we play it safe and just run them, they're not too onerous |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.