feat: add DuckDB join_asof
#1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
added
enhancement
narwhals/_arrow/dataframe.py
Outdated
| strategy: Literal["backward", "forward", "nearest"], | ||
| suffix: str = "_right", |
There was a problem hiding this comment.
really minor, but can we avoid setting the default in the compliant level? So, in narwhals.dataframe.py, we can have suffix: str = "_right", but in the internal methods in _arrow / _duckdb / _pandas_like / etc., we can just have suffix: str, to make sure that we're always passing it down?
narwhals/_duckdb/dataframe.py
Outdated
| strategy: Literal["backward", "forward", "nearest"] = "backward", | ||
| suffix: str = "_right", | ||
| ) -> Self: | ||
| import duckdb |
There was a problem hiding this comment.
i think we can do this at the top of the file
narwhals/_duckdb/dataframe.py
Outdated
| msg = "Only 'backward' and 'forward' strategies are currently supported for DuckDB" | ||
| raise NotImplementedError(msg) | ||
| condition = " and ".join(conditions) | ||
| select = [f'lhs."{x}"' for x in lhs.columns] |
There was a problem hiding this comment.
🤔 does `select = ['lhs.*'] work?
…select all left df cols with star
|
Thank you @MarcoGorelli and @FBruzzesi for your reviews! I addressed your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below